Re: [patch 2/2] cifs: dereferencing first then checking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 02, 2010 at 04:22:50PM -0400, Jeff Layton wrote:
> Here's a respun patch that should fix these problems. I chickened out
> on removing the check in find_writable_file.
> 
> It still seems like a bogus cargo-cult sort of thing. It should
> probably be a BUG() if you call that function with a NULL pointer, but
> I don't feel like tackling that just yet.
> 
> Dan, does this look ok to you? If so, I'll resend to Steve as an
> "official" patch.
> 

Looks fine to me.  Obviously, I've already said that I don't know if the
checks are needed or not.  I defer to your greater knowledge.  ;)

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux