Re: [PATCH 4/5] CIFS: New read logic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 1 Nov 2010 12:41:31 -0500
Steve French <smfrench@xxxxxxxxx> wrote:

> My reaction is that over modern networks 1 second attribute timeout is
> probably ok and 60 seconds is too slow (certainly slowing it down
> beyond 5 seconds could be noticeable to user, not just create a higher
> data integrity risk) - but the obvious exception is over slow
> networks.   Since we can get the SMB echo times - we could base the
> value of actimeout 1 second vs 60 second based on what we estimate
> round trip delay is.
> 

I don't see any connection between the ac timeout and round trip time.
The ac timeout needs to be set according to how often you expect files
to change, and that has no real relation to the RTT between client and
server.

I think all we can reasonably do is try to set a sane default and let
people override it when they need to do so. 60s may well be too long,
but 1s is way, way too short and has significant performance impact
even without Pavel's changes.

-- 
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux