On Thu, 28 Oct 2010 15:07:09 -0500 Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx> wrote: > On Thu, Oct 28, 2010 at 2:58 PM, Jeff Layton <jlayton@xxxxxxxxxx> wrote: > > On Thu, 28 Oct 2010 09:53:07 -0500 > > shirishpargaonkar@xxxxxxxxx wrote: > > > >> From: Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx> > >> > >> > >> Removed following fields from smb session structure > >> cryptkey, ntlmv2_hash, tilen, tiblob > >> and ntlmssp_auth structure is allocated dynamically only if the auth mech > >> in NTLMSSP. > >> > >> response field within a session_key structure is used to initially store the > >> target info (either plucked from type 2 challenge packet in case of NTLMSSP > >> or fabricated in case of NTLMv2 without extended security) and then to store > >> Message Authentication Key (mak) (session key + client response). > >> > >> Server challenge or cryptkey needed during a NTLMSSP authentication > >> is now part of ntlmssp_auth structure which gets allocated and freed > >> once authenticaiton process is done. > >> > >> > >> Signed-off-by: Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx> > > > > Ack, assuming that this is needed for the later NTLMSSP cleanup patch > > to merge. > > > > Acked-by: Jeff Layton <jlayton@xxxxxxxxxx> > > > > Jeff, Thanks. Do you mean prior instead of later? > > [PATCH] NTLM auth and sign - Use appropriate server challenge > > should go in first. But it is not marked as either ack'ed or review'ed yet. > > Regards, > > Shirish > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html Whoops. Must have hit "reply" on the wrong email. Yes...I just sent a corrected ack on that patch. Thanks, -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html