On Wed, Oct 27, 2010 at 12:13:38PM -0400, Jeff Layton wrote:
> > diff --git a/fs/cifs/file.c b/fs/cifs/file.c
> > index 45af003..db7eaf7 100644
> > --- a/fs/cifs/file.c
> > +++ b/fs/cifs/file.c
> > @@ -1031,7 +1031,7 @@ ssize_t cifs_user_write(struct file *file, const char __user *write_data,
> > cifs_stats_bytes_written(pTcon, total_written);
> >
> > /* since the write may have blocked check these pointers again */
> > - if ((file->f_path.dentry) && (file->f_path.dentry->d_inode)) {
> > + if (file->f_path.dentry->d_inode) {
>
> ^^^^^^
> This check is bogus too. An open filp on a negative dentry
> isn't possible, right?
Indeed, it's impossible.
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
