Re: [PATCH] [CIFS] [1/3 -v3] NTLM auth and sign - Allocate session key/client response dynamically

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Ok. I think the locking around the sequence number could stand some
> improvement. It seems a bit complex -- maybe a simple atomic counter
> would be more appropriate? In any case, it's probably better to leave
> that for a later patch.
>
> You can add my reviewed-by on this one. I don't see any obvious
> problems now.
>
> --
> Jeff Layton <jlayton@xxxxxxxxx>
>

Jeff, Thanks. I see three issues that need to be addressed once these
NTLM patches are through.

1. purging code obsolet'ed by kernel crypto apis.
2. revisiting logic in cifs_reconnect()
3. data type and/or locking around sequence_number
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux