On Mon, 25 Oct 2010 07:02:56 +0200
Dan Carpenter <error27@xxxxxxxxx> wrote:
> The cifs_convert_address() returns zero on error but this caller is
> testing for negative returns.
>
> Btw. "i" is unsigned here, so it's never negative.
>
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index 7e73176..ad6a4ea 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -1064,7 +1064,7 @@ cifs_parse_mount_options(char *options, const char *devname,
> }
> i = cifs_convert_address((struct sockaddr *)&vol->srcaddr,
> value, strlen(value));
> - if (i < 0) {
> + if (i == 0) {
> printk(KERN_WARNING "CIFS: Could not parse"
> " srcaddr: %s\n",
> value);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Good catch. Looks right to me.
Reviewed-by:
--
Jeff Layton <jlayton@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
