On Sun, Oct 17, 2010 at 10:08 AM, Suresh Jayaraman <sjayaraman@xxxxxxx> wrote: > > On 10/16/2010 01:03 AM, Jeff Layton wrote: > > Eliminate the poor, misunderstood "oflags" option from cifs_new_fileinfo. > > The callers mostly pass in the filp->f_flags here. > > > > That's not correct however since we're checking that value for > > the presence of FMODE_READ. Luckily that only affects how the f_list is > > ordered. What it really wants here is the file->f_mode. Just use that > > field from the filp to determine it. > > > > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx> > > --- > > fs/cifs/cifsproto.h | 3 +-- > > fs/cifs/dir.c | 9 ++++----- > > fs/cifs/file.c | 5 ++--- > > 3 files changed, 7 insertions(+), 10 deletions(-) > > > > Looks good to me. > > Reviewed-by: Suresh Jayaraman <sjayaraman@xxxxxxx> Thx - Looks like these last two patches eliminate some of the annoying sparse warnings too. Down to only a few: fs/cifs/dir.c:275:21: warning: restricted fmode_t degrades to integer fs/cifs/dir.c:277:21: warning: restricted fmode_t degrades to integer -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
