On Mon, Oct 11, 2010 at 2:07 PM, Jeff Layton <jlayton@xxxxxxxxxx> wrote: > Eliminate the poor, misunderstood "oflags" option from cifs_new_fileinfo. > The callers mostly pass in the filp->f_flags here. > > That's not correct however since we're checking that value for > the presence of FMODE_READ. Luckily that only affects how the f_list is > ordered. What it really wants here is the file->f_mode, but this check > really makes no sense whatsoever. FMODE_READ will be set for O_RDWR or > O_RDONLY opens. So this in effect just moves those to the front of the > list and leaves O_WRONLY at the end. > > That might make some sense if more things paid attention to the list > order, but the only thing that does is find_readable_file, which uses > it to stop scanning the list when it hits a write-only one. Removing a small optimization for small simplification of code seems less useful type of patch. Not sure how often the acl calls get hit - but it is remotely possible that this could affect performance. -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
