On Mon, 11 Oct 2010 12:27:47 -0500 Steve French <smfrench@xxxxxxxxx> wrote: > You are right - find_writeable_file is the common one, not > find_readable_file (might make sense to reverse the ordering - > readonly files at end instead of writeonly files at end - given > find_readable_file is called less often). There are cases with a > file opened many times from different processes that I have seen. > Not sure why removing the ordering matters much - it is a possible, > albeit usually slight, performance benefit to keep file handles we are > most likely to want at the top of the list. > If we were really concerned about performance here, fine-grained locking would get us much farther toward that goal. I'm concerned about people breaking the list order, which has obviously been broken for some time and no one has noticed. Eventually I want to overhaul all of the find_readable/writable_file code with a better interface. That will be simpler if I don't have to deal with unnecessary complexity like the list ordering here. -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
