Re: [PATCH] cifs: on multiuser mount, set ownership to current_fsuid/current_fsgid (try #5)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 7 Oct 2010 22:25:23 -0500
Steve French <smfrench@xxxxxxxxx> wrote:

> One case does seem strange - I forgot what happens when you specify a
> mnt_uid of 0 (root)
> 

Oof, you're right... we should base this on CIFS_MOUNT_OVERR_UID and
CIFS_MOUNT_OVERR_GID flags instead. I'll send a fixed patch once I've
tested it.

Now that I think about this though, maybe we shouldn't do this based on
CIFS_MOUNT_MULTIUSER but instead on CIFS_MOUNT_NO_PERM? It would mean
a behavior change for anyone currently "-o noperm" on a mount without
unix extensions but I think it would make a bit more sense than special
casing CIFS_MOUNT_MULTIUSER here.

Thoughts?
-- 
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux