Re: [PATCH 00/14] cifs: clean up management of open filehandles

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/04/2010 11:22 PM, Jeff Layton wrote:
> This patchset fixes a number of problems with the existing CIFS code. It
> eliminates the backreference to the filp from cifsFileInfo, allowing a
> cifsFileInfo to outlive the filp that it was generated against.
> 
> With that change, most of the closing of a filehandle on the server is
> moved to cifsFileInfo_put. cifs_close is then changed to just put the
> filehandle instead of trying to wait around for existing users to
> finish with it.
> 
> With this change, there is some further cleanup that can be done as
> well. For instance, there's no real need to continually search for new
> filehandles in cifs_writepages now that we hold a reference to one. I'll
> hold back on that until I know how this set has been received.
> 

Nice cleanups. Patches 1 to 9 looks correct to me.


Reviewed-by: Suresh Jayaraman <sjayaraman@xxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux