Re: [PATCH 09/15] cifs: have cifsFileInfo hold a reference to a tlink rather than tcon pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 20, 2010 at 6:01 PM, Jeff Layton <jlayton@xxxxxxxxxx> wrote:
> cifsFileInfo needs a pointer to a tcon, but it doesn't currently hold a
> reference to it. Change it to keep a pointer to a tcon_link instead and
> hold a reference to it.

Nice work on these patches but they do end up more complex than I expected
(may be unavoidable).

Before committing the last set - are we sure that there is no way we could have
done the list of tids/uids off the same tcon or simplify.  For example (may be
impractical, but worth considering) - if we limited many of these changes to
init_smb itself - if in init_smb we see a request from local uid that does not
have an smb uid negotiated, we negotiate/sessionsetup/tcon
there (as we do reconnect today in some cases) to get the new tid - this does
have the problem of not knowing the uid of the opener of a file though so
perhaps not problem.

Your way may be better - but it is a much bigger change.

-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux