> + struct cifsInodeInfo *cinode; > + > + if (filp && filp->f_path.dentry && filp->f_path.dentry->d_inode) > + cinode = CIFS_I(filp->f_path.dentry->d_inode); > + else > + return -ENOENT; Totally pointless check. Could you guys please stop putting in all these utterly pointless cargo cult checks in cifs? > + > + if (cinode->clientCanCacheRead) > + read = do_sync_read(filp, buf, len, ppos); > + else > + read = cifs_user_read(filp, buf, len, ppos); > + > + return read; And how do you enforce your caching semantics for aio or vectored reads? -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html