On Tue, Sep 7, 2010 at 1:08 PM, Steve French <smfrench@xxxxxxxxx> wrote: > On Tue, Sep 7, 2010 at 12:21 PM, Ben Greear <greearb@xxxxxxxxxxxxxxx> wrote: >> >> Here's a compile-tested patch to enable srcaddr= for smb2. >> >> It converts a bit of smb2 to be more like cifs (seems smb2 was copy >> and pasted and then cifs moved on). >> >> It also seems like much of the common code could move to a >> helper module or something...way too much similarity between >> cifs and smb2 to have all that duplication. > > Yes - the goal is to move to common parsing for (cifs and smb2) ip addresses and > five or six other areas. There was a modest step toward common code > recently with > the move of the dns resolver to common code in 2.6.36. Forgot to mention that there are differences in SMB2 vs. CIFS in use of port 139 (and RFC1001 as well) but shouldn't affect your patch. -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
