On Mon, Aug 30, 2010 at 12:25 PM, Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote: > On Mon, 30 Aug 2010 12:14:53 -0500 Shirish Pargaonkar wrote: > >> On Mon, Aug 30, 2010 at 12:00 PM, Suresh Jayaraman <sjayaraman@xxxxxxx> wrote: >> > (Cc linux-cifs@xxxxxxxxxxxxxxx) >> > >> > Couldn't get a chance to check this, but I guess this is perhaps due to >> > the recent crypto patches.. >> >> Suresh, yes, cifs auth and signing code using kernel crypto (shash) apis. >> >> fs/cifs/Kconfig >> >> select CRYPTO_MD5 >> select CRYPTO_ARC4 >> > > Either CIFS should depend on CRYPTO: > change > depends on INET > to > depends on INET && CRYPTO > > or it can also select CRYPTO. > >> >> > >> > On 08/30/2010 02:17 PM, Miguel Calleja wrote: >> >> CIFS does not build without CRYPTO selected. OK - will fix this for cifs. Looks like ecryptfs chose "depends on CRYPTO" and ubifs chose "select CRYPTO" - but for network file system seems like "select CRYPTO" (rather than depends on) makes more sense. The ceph file system seems like it has the same type of problem. fs/ceph/Kconfig has "select CRYPTO_AES" but not "select CRYPTO" -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html