Reviewed and merged into cifs-2.6.git On Mon, Aug 23, 2010 at 10:38 AM, Jeff Layton <jlayton@xxxxxxxxxx> wrote: > > It's possible for a cifsSesInfo struct to have a NULL password, so we > need to check for that prior to running strncmp on it. > > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx> > --- > fs/cifs/connect.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c > index 18af707..ec0ea4a 100644 > --- a/fs/cifs/connect.c > +++ b/fs/cifs/connect.c > @@ -1673,6 +1673,7 @@ cifs_find_smb_ses(struct TCP_Server_Info *server, struct smb_vol *vol) > MAX_USERNAME_SIZE)) > continue; > if (strlen(vol->username) != 0 && > + ses->password != NULL && > strncmp(ses->password, > vol->password ? vol->password : "", > MAX_PASSWORD_SIZE)) > -- > 1.7.2.1 > -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html