Interesting.
Generally seems like a good idea.
Jeff made two valid review comments already (on the kmalloc vs. stack,
and the kernel coding style) but note that scripts/checkpatch.pl will
catch additional minor coding style things:
stevef@stevef-laptop:~/smb2$ scripts/checkpatch.pl ~/sm1.patch
WARNING: braces {} are not necessary for single statement blocks
#62: FILE: fs/cifs/link.c:120:
+ if (rc != 0) {
+ return rc;
+ }
Could you clean up the things scripts/checkpatch.pl (and sparse
issues, ie "make modules C=1" -- if any)
On Tue, Aug 3, 2010 at 10:05 AM, Stefan Metzmacher <metze@xxxxxxxxx> wrote:
> Hi Steve,
>
> The following patchset adds support Minshall+French symlinks for Linux.
> See http://wiki.samba.org/index.php/UNIX_Extensions#Minshall.2BFrench_symlinks
>
> I've added a new mount option 'mfsymlinks', which is off by default.
>
> If the option is pass to a mount, Minshall+French symlinks will be used
> to support symlinks for the local client.
>
> This is compatible with the Darwin implementation.
>
> Can you review this patches? It would be wonderful if they would endup
> in Linux 2.6.36.
>
> metze
>
>
--
Thanks,
Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
