Re: [PATCH] cifs: account for new creduid=0x%x parameter in spnego upcall string

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



looks fine

On Tue, Aug 3, 2010 at 9:20 AM, Jeff Layton <jlayton@xxxxxxxxxx> wrote:
> The commit that added the creduid=0x%x parameter failed to increase the
> buffer allocation to account for it.
>
> Reported-by: J. Bruce Fields <bfields@xxxxxxxxxxxx>
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
> ---
>  fs/cifs/cifs_spnego.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/fs/cifs/cifs_spnego.c b/fs/cifs/cifs_spnego.c
> index 6effccf..8704490 100644
> --- a/fs/cifs/cifs_spnego.c
> +++ b/fs/cifs/cifs_spnego.c
> @@ -84,6 +84,9 @@ struct key_type cifs_spnego_key_type = {
>  /* strlen of ";uid=0x" */
>  #define UID_KEY_LEN            7
>
> +/* strlen of ";creduid=0x" */
> +#define CREDUID_KEY_LEN                11
> +
>  /* strlen of ";user=" */
>  #define USER_KEY_LEN           6
>
> @@ -107,6 +110,7 @@ cifs_get_spnego_key(struct cifsSesInfo *sesInfo)
>                   IP_KEY_LEN + INET6_ADDRSTRLEN +
>                   MAX_MECH_STR_LEN +
>                   UID_KEY_LEN + (sizeof(uid_t) * 2) +
> +                  CREDUID_KEY_LEN + (sizeof(uid_t) * 2) +
>                   USER_KEY_LEN + strlen(sesInfo->userName) +
>                   PID_KEY_LEN + (sizeof(pid_t) * 2) + 1;
>
> --
> 1.7.2
>
>



-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux