Re: [PATCH] cifs: fsc should not default to "on"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



agreed - merged

On Mon, Jul 26, 2010 at 1:25 PM, Jeff Layton <jlayton@xxxxxxxxxx> wrote:
> I'm not sure why this was merged with this flag hardcoded on, but it
> seems quite dangerous. Turn it off.
>
> Also, mount.cifs hands unrecognized options off to the kernel so there
> should be no need for changes there in order to support this.
>
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
> ---
>  fs/cifs/connect.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index 85a994c..2a43a0a 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -846,9 +846,6 @@ cifs_parse_mount_options(char *options, const char *devname,
>        /* default to using server inode numbers where available */
>        vol->server_ino = 1;
>
> -       /* XXX: default to fsc for testing until mount.cifs pieces are done */
> -       vol->fsc = 1;
> -
>        if (!options)
>                return 1;
>
> --
> 1.7.1.1
>
>



-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux