Re: [PATCH 2/4] Implement a DNS Resolver Module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 20, 2010 at 10:25 AM, Jeff Layton <jlayton@xxxxxxxxxx> wrote:
> On Wed, 07 Jul 2010 10:14:11 +0100
> David Howells <dhowells@xxxxxxxxxx> wrote:
>
>> From: Wang Lei <wang840925@xxxxxxxxx>
>>
>
> ----------------[snip]------------------
>
>> +/**
>> + * dns_resolve_unc_to_ip - Resolve UNC server name to ip address.
>> + * @unc: UNC path specifying the server
>> + * @ip_addr: Where to return the IP address.
>> + *
>> + * The IP address will be returned in string form, and the caller is
>> + * responsible for freeing it.
>> + *
>> + * Returns 0 on success, -ve on error.
>> + */
>> +int
>> +dns_resolve_unc_to_ip(const char *unc, char **ip_addr)

> Another (somewhat minor) nit that Steve F pointed out. The function
> that this replaces in cifs can deal with numeric scopeid's as part of
> the address. For instance:
>
>    fea1::1%2
>
> ...where the scopeid here is "2". For linux machines, the scopeid
> essentially equates to an interface index and really has no meaning
> outside of the machine.
>
> It's not clear to me that we'd ever see one of those in a hostname that
> we want to parse here, but it might not hurt to plan for it and deal
> with it appropriately.

I think it is plausible that the scopeid/interface matters here (I heard the
request before and it seems reasonable).   For IPv6 in UNC names
Windows maps : to -- IIRC so scope ids look a little different,
but I think they support them

-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux