On 06/23/2010 10:21 PM, David Howells wrote: > Suresh Jayaraman <sjayaraman@xxxxxxx> wrote: > >> + rc = cifs_fscache_register(); >> + if (rc) >> + goto out; >> + >> rc = cifs_init_inodecache(); >> if (rc) >> goto out_clean_proc; >> @@ -949,8 +954,10 @@ init_cifs(void) >> cifs_destroy_mids(); >> out_destroy_inodecache: >> cifs_destroy_inodecache(); >> + cifs_fscache_unregister(); >> out_clean_proc: > > This is incorrect. You need to call cifs_fscache_unregister() if > cifs_init_inodecache() fails. > Doh! I'll fix it. -- Suresh Jayaraman -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
