On Mon, 7 Jun 2010 00:20:14 -0400 Scott Lovenberg <scott.lovenberg@xxxxxxxxx> wrote: > > > > > - if (strncmp(token, "dir_mode", 8) == 0) > > > + if (strncmp(token, "dir_mode", 4) == 0 || strncmp(token, "dirm", 4) > > == 0) > > ^^^^ > > Sigh. But I can confirm that this is similarly broken in the kernel > > so we have little choice but to live with it here. > > > > That's exactly how I felt about this fix. Do you have any feelings on > fixing this on both sides to accept only the full strings? It might cause > regressions for people, so the kernel patch will probably be pulled by > Redhat, Suse and Debian (and anyone else backporting kernel patches for long > term releases) maintainers. > It seems like the right thing to do, but if it's just going to cause extra > work and be yanked either way... well, that's one step forward, two > backwards. > > I think we're stuck living with it like this. The maintenance burden on this sort of thing is fairly low so it's not really a big deal. This is a good reason why we have to consider user-visible interfaces very carefully however. -- Jeff Layton <jlayton@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
