Hi Geert, Thanks for the feedback. > -----Original Message----- > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > Sent: 14 March 2025 14:48 > Subject: Re: [PATCH v4 11/11] can: rcar_canfd: Add RZ/G3E support > > Hi Biju, > > On Thu, 6 Mar 2025 at 13:43, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > > The CAN-FD IP found on the RZ/G3E SoC is similar to R-Car Gen4, but it > > has no external clock instead it has clk_ram, it has 6 channels and > > supports 20 interrupts. Add support for RZ/G3E CAN-FD driver. > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > Thanks for your patch! > > > --- a/drivers/net/can/rcar/rcar_canfd.c > > +++ b/drivers/net/can/rcar/rcar_canfd.c > > @@ -1979,6 +1991,7 @@ static int rcar_canfd_probe(struct platform_device *pdev) > > u32 rule_entry = 0; > > bool fdmode = true; /* CAN FD only mode - default */ > > char name[9] = "channelX"; > > + struct clk *clk_ram; > > int i; > > > > info = of_device_get_match_data(dev); @@ -2068,6 +2081,11 @@ > > static int rcar_canfd_probe(struct platform_device *pdev) > > gpriv->extclk = !gpriv->info->only_internal_clks; > > } > > > > + clk_ram = devm_clk_get_optional_enabled(dev, "ram_clk"); > > + if (IS_ERR(clk_ram)) > > + return dev_err_probe(dev, PTR_ERR(clk_ram), > > + "cannot get ram clock\n"); > > + > > clk_ram is unused. clk_ram is local variable and is used for error checking. devm_clk_get_optional_enabled() is dev-res managed clock and the will be enabled during probe() and get disabled during unbind similar to "fck". Am I missing anything here? Please let me know. Cheers, Biju
