Hi Biju, On Thu, 6 Mar 2025 at 13:43, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > R-Car Gen4 has shared regs for both CAN-FD and Classical CAN operations. > Add shared_can_regs variable to struct rcar_canfd_hw_info to handle this > difference. > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> Thanks for your patch! Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> One nit below. > --- a/drivers/net/can/rcar/rcar_canfd.c > +++ b/drivers/net/can/rcar/rcar_canfd.c > @@ -517,6 +517,7 @@ struct rcar_canfd_hw_info { > unsigned shared_global_irqs:1; /* Has shared global irqs */ > unsigned multi_channel_irqs:1; /* Has multiple channel irqs */ > unsigned ch_interface_mode:1; /* Has channel interface mode */ > + unsigned shared_can_reg:1; /* Has shared classical can registers */ shared_can_regs? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds