Dear Vincent,
Thank you for reviewing,
this part is as Marc mentioned.
Best regards,
Ming
Vincent Mailhol <mailhol.vincent@xxxxxxxxxx> 於 2025年2月7日 週五 下午11:01寫道：
>
> On 07/02/2025 at 21:15, Marc Kleine-Budde wrote:
> > On 07.02.2025 15:44:59, Ming Yu wrote:
>
> (...)
>
> >> +static netdev_tx_t nct6694_can_start_xmit(struct sk_buff *skb,
> >> + struct net_device *ndev)
> >> +{
> >> + struct nct6694_can_priv *priv = netdev_priv(ndev);
> >> +
> >> + if (can_dev_dropped_skb(ndev, skb))
> >> + return NETDEV_TX_OK;
> >> +
> >> + netif_stop_queue(ndev);
> >> + can_put_echo_skb(skb, ndev, 0, 0);
> >> + queue_work(priv->wq, &priv->tx_work);
>
> What is the reason to use a work queue here? xmit() is not a hard IRQ.
> Also, the other USB CAN devices just directly send the USB message in
> their xmit() without the need to rely on such worker.
>
> Sorry if this was discussed in the past, I can not remember if this
> question has already been raised.
>
> >> + return NETDEV_TX_OK;
> >> +}
>
> (...)
>
> Yours sincerely,
> Vincent Mailhol
>
