Re: [PATCH] can: rcar_canfd: Use of_get_available_child_by_name()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/02/2025 at 03:52, Sergey Shtylyov wrote:
> On 2/1/25 12:46 PM, Biju Das wrote:
> 
>> Simplify rcar_canfd_probe() using of_get_available_child_by_name().
>>
>> Simplify rcar_canfd_probe() using of_get_available_child_by_name().
> 
>    Twice? :-)

+1

>> While at it, move of_node_put(child) inside the if block to avoid
>> additional check if of_child is NULL.
>>
>> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> [...]

Please remove the repetition. Aside from that, the patch is good.

Reviewed-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>


Yours sincerely,
Vincent Mailhol





[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux