Hi Marc, > -----Ursprüngliche Nachricht----- > Von: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> > Gesendet: Dienstag, 21. Januar 2025 10:32 > An: Jonas Mark (BT-FS/ENG1-Mue) <mark.jonas@xxxxxxxxxxxx> > Cc: linux-can@xxxxxxxxxxxxxxx; Streidl Hubert (BT-FS/ENG1-Mue) > <Hubert.Streidl@xxxxxxxxxxxx> > Betreff: Re: AW: [can-utils][PATCH 2/3] canbusload: support busload > statistic > > On 21.01.2025 07:51:50, Jonas Mark (BT-FS/ENG1-Mue) wrote: > > > Had to make this a "static" function, otherwise it fails to link. > > > Some singed/unsigned changes were also needed. Can you check if > this > > > still works for you: > > > > > > | https://github.com/linux-can/can-utils/pull/571 > > > > > > So far compile tested only. We compiled and tested the code from https://github.com/marckleinebudde/can-utils/tree/cangen-canbusload. It works as expected. Thank you for the fixes. > > Thank you for your feedback. We'll have a look it by the end of the > week. > > > > We compiled and tested with Ubuntu 22.04 on amd64 (standard PC). > That > > is, we used gcc 11.4 and ld (binutils) 2.38. For us it linked > > flawlessly and compiled without warnings. Which version of gcc and > ld > > did you use? > > It basically fails on all of our CI plaforms (ubuntu and debian): > > | https://github.com/linux-can/can- > utils/actions/runs/12872465505/job/35 > | 887996190 We now understood what the problem was: We only compiled using gcc but the project supports gcc and clang. So we missed the clang problems we introduced. Next time we'll use the project's GitHub actions to validate our code. Cheers, Mark
