On 03.01.2025 13:37:19, Sean Nyekjaer wrote: > On Fri, Nov 22, 2024 at 03:52:21PM +0100, Sean Nyekjaer wrote: > > When downing the tcan4x5x there is no reason to keep the tcan4x5x in > > "normal" mode and waste power. > > So set standby mode when the interface is down and normal mode when > > interface is up. > > > > Also when going into suspend, set the tcan4x5x into standby mode. The > > tcan4x5x can still be used as a wake-source when in standby as low power > > rx is enabled. > > > > Signed-off-by: Sean Nyekjaer <sean@xxxxxxxxxx> > > --- > > Changes in v3: > > - Run deinit in m_can_stop() in any case even if m_can_cccr_update_bits() fails > > - Link to v2: https://lore.kernel.org/r/20241115-tcan-standby-v2-0-4eb02026b237@xxxxxxxxxx > > > > Changes in v2: > > - Reduced code in tcan4x5x_deinit() > > - Taken care of return values from deinit callback > > - Link to v1: https://lore.kernel.org/r/20241111-tcan-standby-v1-0-f9337ebaceea@xxxxxxxxxx > > > > --- > > Hi, > > Anything needed from my side on this? I think this all could be hidden behind runtime PM, but that would mean a bigger re-write and a lot of testing. So applied to linux-can-next as is. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung Nürnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Attachment:
signature.asc
Description: PGP signature
