Re: AW: net: m_can: missing mutexes in tx_work_queue and isr-handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10.12.2024 15:04:29, Prückl Thomas wrote:
> > Can you show us the patch?
> 
> My current patch currently just locks the isr and work queue.
> I guess that additional locks are necessary too (e.g. in m_can_close)
> 
> Subject: [PATCH] can: m_can: added mutex to lock isr and tx work queue

Can you make the locking finer, I mean only lock the register access
which is critical? And keep in mind, that you cannot use mutexes from
the non-threaded IRQ handler, i.e. in non-peripheral mode.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux