Hi, I am done reading (and understanding) ISO 11898-1:2024, so let's resume the work! On 04/12/2024 at 16:56, Oliver Hartkopp wrote: > Hi Vincent, > > On 03.12.24 10:45, Vincent Mailhol wrote: > >>> https://lore.kernel.org/linux-can/20241201112333.6950-1- >>> socketcan@xxxxxxxxxxxx/T/#u >>> https://lore.kernel.org/linux-can/20241201112230.6917-1- >>> socketcan@xxxxxxxxxxxx/T/#t > >> Thanks for all the testing and the fixes. Because of the lack of >> testing of this RFC on my side, I was expecting such issues. But I >> really appreciate that you took time to investigate and debug, really >> helpful! I will make sure to incorporate these fixes in the next >> version. > > I'll send out an extended RFC V2 which is my current test base for you > in some minutes. > > Either for the kernel and iproute2 there are two new patches that add > new controlmode flags. > >> The next series I send will add the pwm and drop the RFC patch. > > Excellent! > > I assume it will follow the TDC pattern with > CAN_CTRLMODE_XL_PWM_AUTO and CAN_CTRLMODE_XL_PWM_MANUAL > or something similar? I am not sure why we would need a tristate here. The reason why I put the tristate for the TDC is because some transceiver (the majority) will automatically measure TDCV but some may give the option for the user to manually set it.
