On Tue, Nov 05, 2024 at 12:48:23PM +0300, Dmitry Antipov wrote: > Since 'j1939_session_skb_queue()' do an extra 'skb_get()' for each > new skb, I assume that the same should be done for an initial one > in 'j1939_session_new()' just to avoid refcount underflow. > > Reported-by: syzbot+d4e8dc385d9258220c31@xxxxxxxxxxxxxxxxxxxxxxxxx > Closes: https://syzkaller.appspot.com/bug?extid=d4e8dc385d9258220c31 > Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol") > Signed-off-by: Dmitry Antipov <dmantipov@xxxxxxxxx> Tested-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> Acked-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
