Re: [PATCH] can: rockchip_canfd: Drop obsolete dependency on COMPILE_TEST

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 22, 2024 at 3:33 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> On Thu, Nov 21, 2024 at 2:50 PM Jean Delvare <jdelvare@xxxxxxx> wrote:
> > On Tue, 12 Nov 2024 12:15:06 +0100 (CET), Geert Uytterhoeven wrote:
> > > On Tue, 22 Oct 2024, Vincent MAILHOL wrote:
> > > > On Tue. 22 Oct. 2024 at 20:06, Jean Delvare <jdelvare@xxxxxxx> wrote:
> > > >> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), OF
> > > >> can be enabled on all architectures. Therefore depending on
> > > >> COMPILE_TEST as an alternative is no longer needed.
> > > >
> > > > I understand the motivation behind this patch, but for me, as a
> > > > maintainer, it becomes more work when I want to do a compile test.
> > > > Before I would have needed to only select COMPILE_TEST but now, I
> > > > would need to remember to also select OF for that driver to appear in
> > > > the menuconfig.
> > >
> > > IMHO these are two different things: to get a working driver, you need
> > > to enable OF;
> >
> > True.
> >
> > >(...) to do (may be limited, i.e. may not give a working driver)
> > > compile-testing, you need to enable COMPILE_TEST.
> >
> > No, you don't *need* it. Enabling COMPILE_TEST is (or was) one way to
> > do compile-testing, but it was not the only way. Which is the reason
> > why it was dropped.
>
> You could still do it the other way, by enabling CONFIG_OF.

And you still need to enable COMPILE_TEST, to get around the
ARCH_ROCKCHIP dependency...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds





[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux