Hello Nicolai, thanks for your contribution! On 21.11.2024 16:02:09, Nicolai Buchwitz wrote: > The current implementation of can_set_termination() sets the GPIO in a > context which cannot sleep. This is an issue if the GPIO controller can > sleep (e.g. since the concerning GPIO expander is connected via SPI or > I2C). Thus, if the termination resistor is set (eg. with ip link), > a warning splat will be issued in the kernel log. > > Fix this by setting the termination resistor with > gpiod_set_value_cansleep() which instead of gpiod_set_value() allows it to > sleep. > > Cc: stable@xxxxxxxxxxxxxxx > Signed-off-by: Nicolai Buchwitz <nb@xxxxxxxxxxx> I've send the same patch a few hours ago: https://lore.kernel.org/all/20241121-dev-fix-can_set_termination-v1-1-41fa6e29216d@xxxxxxxxxxxxxx/ Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung Nürnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Attachment:
signature.asc
Description: PGP signature
