On 12 nov. 2024 à 17:53, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> a écrit : > On 11.11.2024 00:55:49, Vincent Mailhol wrote: > > Because of popular request [1] and to celebrate the fact that I joined > > the kernel web of trust this week [2], here is an RFC to introduce the > > CAN XL netlink support. > > yeay \o/ > > > The logic is simple. The CAN XL basically just reuse the same kind of > > parameters as CAN FD: the databittiming and the TDC. So the series is > > just a bunch of refactor to either: > > > > - factorize code. > > - rename some variable to differentiate between CAN FD and XL. > > - make some function more generic to accept both CAN FD and XL. > > > > The feature is working™: there is a dummy driver at the end of the > > series to show the traffic from the userland to a driver. This said, I > > did close to zero testing. Once I had one CAN XL frame reaching the > > driver, I call it a day, and decided to send the work. Regardless, it > > is Sunday night. If I do not send it now, that would be next week-end. > > Probably some mistakes are hidden here and there, but this should be > > enough for an RFC level. > > > > Also, I am not fully happy that can_dbt_changelink() requires 8 > > parameters. I will probably revisit this later on. But for the moment, > > I think this is acceptable for an RFC. > > > > Overall, I do not want to rush this series. Linus should send the rc7 > > anytime soon, and the merge window will probably start in eight days. > > I do not think this series will be finalized by then. I still need to > > give a deeper look at ISO 11898-1:2024 [3] to check that everything is > > good. However, if I receive positive feedback on this RFC, I would > > probably like to have the first patch merged so that I do not have to > > rebase that tree wide patch each time someone makes a change. > > > > I will send a second RFC series for iplink2 just after this one. Stay > > tuned! > > What's the base commit of this series? It doesn't apply to > net-next/main. For a series this big, try using 'b4', it also > automatically sends the base commit. It is linux-can-next/main. I will rebase at least the first patch and maybe some of the trivial renaming onto net-next/main before the merge window opens. This way, we will not have to worry about these anymore. After this, the other patches should apply smoothly. Yours sincerely, Vincent Mailhol
