Re: [RFC PATCH 8/8] iplink_can: add CAN XL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 11.11.24 16:03, Vincent Mailhol wrote:
On 11/11/2024 at 23:13, Oliver Hartkopp wrote:
On 10.11.24 17:01, Vincent Mailhol wrote:
Signed-off-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>
---
  ip/iplink_can.c | 209 +++++++++++++++++++++++++++++++++++++++++++++---
  1 file changed, 196 insertions(+), 13 deletions(-)

diff --git a/ip/iplink_can.c b/ip/iplink_can.c
index 54acc65c..43018c54 100644
--- a/ip/iplink_can.c
+++ b/ip/iplink_can.c
@@ -26,6 +26,10 @@ static void print_usage(FILE *f)
          "\t[ dtq TQ dprop-seg PROP_SEG dphase-seg1 PHASE-SEG1\n \t dphase-seg2 PHASE-SEG2 [ dsjw SJW ] ]\n"
          "\t[ tdcv TDCV tdco TDCO tdcf TDCF ]\n"
          "\n"
+        "\t[ xl-dbitrate BITRATE [ xl-dsample-point SAMPLE-POINT] ] |\n" +        "\t[ xl-dtq TQ xl-dprop-seg PROP_SEG xl-dphase-seg1 PHASE- SEG1\n \t  xl-dphase-seg2 PHASE-SEG2 [ xl-dsjw SJW ] ]\n"
+        "\t[ xl-tdcv TDCV xl-tdco TDCO xl-tdcf TDCF ]\n"

s/xl-d/x/ ?

xsample-point seems more handy than xl-dsample-point

Makes sense. Then, what about:

   sed -i "s/xl-d/x/g;s/xl-/x/g" ip/iplink_can.c

This will give:

   - xbitrate, xtq, xprop-seg, xphase-seg2, xsjw
   - xtdc-mode, xtdcv, xtdco, xtdcf

Note that the above sed command is fully functional. I already staged it in my local repo, works fine. I will not send a new series just for this one. Instead, you can just try the sed command and tell me what you think!

Yes, that's nice!

I can see that even without running sed ;-)

Many thanks!
Oliver





[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux