Subject: Alignment correction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Arg, I forgot to point out the wrong indentation in my last message.
> The second line should be aligned with the first one.
>
> You can see the problem by using the checkpatch.pl tool on your patch:
>
>   $ ./scripts/checkpatch.pl <path_to_your_patch>
>   (...)
>   CHECK: Alignment should match open parenthesis
>   #217: FILE: drivers/net/can/usb/gs_usb.c:1426:
>   +    rc = usb_find_common_endpoints(intf->cur_altsetting,
>   +                                    &ep_in, &ep_out, NULL, NULL);

Thank you Vincent. I will do v6 for it.

> Maybe you set the tab length to 4 columns in your editor? Here, the
> tabulation width is eight. If you need some different settings for
> some different project, then I recommend you to configure your editor
> to rely on the .editorconfig file:
>
>   https://git.kernel.org/torvalds/c/5a602de99797

Thank you for pointing on it. It looks very interesting to me. I will take a look.

Best regards,
Alexander Kozhinov




[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux