On 24.09.2024 00:41:04, Francesco Dolcini wrote:
> Hello Marc,
>
> On Mon, Sep 23, 2024 at 04:36:16PM +0200, Marc Kleine-Budde wrote:
> > On 23.09.2024 14:00:27, Francesco Dolcini wrote:
> > > On Mon, Sep 23, 2024 at 01:57:07PM +0200, Marc Kleine-Budde wrote:
> > > > On 23.09.2024 13:53:10, Francesco Dolcini wrote:
> > > > > I got the following Oops on doing a simple ip link set canX up, running
> > > > > on an i.MX8MM SoC.
> > > > >
> > > > > This was reproduced with some automated testing, I have not tried to
> > > > > reproduce it so far. Any idea or hint? It seems systematic, introduced
> > > > > around 12th september on the v6.6.y branch.
> > > >
> > > > Which Kernel version are you using?
> > >
> > > v6.6.52 is reproducing the issue, I guess it started on some previous
> > > v6.6.x kernel (with x < 52), but I was not able to dig out the logs
> > > running on older kernel from our automated testing (yet).
> > >
> > > I was not able to test mainline (yet).
> >
> > Can you cherry-pick these and see if it fixes your problem?
> >
> > 51b2a7216122 ("can: mcp251xfd: properly indent labels")
> > a7801540f325 ("can: mcp251xfd: move mcp251xfd_timestamp_start()/stop() into mcp251xfd_chip_start/stop()")
>
> Yes, these 2 commits fix the issue.
> In addition I noticed that also 6.1.111 is affected by the exact same Oops.
>
> Thanks!
Thanks for testing!
> BTW, to reproduce, just
>
> ip link set can0 type can bitrate 1000000
> ip link set can0 up
>
> How to we move forward now? Would you ask greg to backport to stable kernel also
> these 2 patches
Yeah, that's pretty much what I'm going to do now :).
> (I assume that something was backported that broke the
> functionality at some point)?
Yes, it's:
upstream:
| 24436be590c6 ("can: mcp251xfd: rx: add workaround for erratum DS80000789E 6 of mcp2518fd")
v6.6:
| 5ea24ddc26a7 ("can: mcp251xfd: rx: add workaround for erratum DS80000789E 6 of mcp2518fd")
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Attachment:
signature.asc
Description: PGP signature
