[no subject]

**Date** **Thread**

<begin quote>
The standard 64-bit addressing device would do something like this:

dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64))

dma_set_mask_and_coherent() never return fail when DMA_BIT_MASK(64).
Typical error code like:

/* Wrong code */
if (dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64)))
        dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32))

dma_set_mask_and_coherent() will never return failure when bigger than 32.
So typical code like:

/* Recommended code */
if (support_64bit)
        dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
else
        dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32));
<end quote>

In Kvaser's case all CAN PCIe devices support 64-bit addressing.

Should I still change the patch as per your suggestion?

Best regards

Martin Jocic
Kvaser AB