On 30.07.2024 13:21:58, Rob Herring wrote: > On Mon, Jul 29, 2024 at 03:05:32PM +0200, Marc Kleine-Budde wrote: > > Add the binding of the rockchip rk3568 CAN-FD controller to the device > > tree bindings documentation. > > Subject line space is valuable. Don't say 'binding' twice. Or anything > else for that matter. > > > Co-developed-by: Elaine Zhang <zhangqing@xxxxxxxxxxxxxx> > > Signed-off-by: Elaine Zhang <zhangqing@xxxxxxxxxxxxxx> > > Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> > > --- > > .../bindings/net/can/rockchip,canfd.yaml | 76 ++++++++++++++++++++++ > > MAINTAINERS | 7 ++ > > 2 files changed, 83 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/can/rockchip,canfd.yaml b/Documentation/devicetree/bindings/net/can/rockchip,canfd.yaml > > new file mode 100644 > > index 000000000000..85f7ea68d8b9 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/can/rockchip,canfd.yaml > > @@ -0,0 +1,76 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/can/rockchip,canfd.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: > > + Rockchip CAN-FD controller > > + > > +maintainers: > > + - Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> > > + > > +allOf: > > + - $ref: can-controller.yaml# > > + > > +properties: > > + compatible: > > + oneOf: > > + - const: rockchip,rk3568-canfd > > + - items: > > + - enum: > > + - rockchip,rk3568v2-canfd > > + - rockchip,rk3568v3-canfd > > + - const: rockchip,rk3568-canfd > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 2 > > + > > + clock-names: > > + items: > > + - const: baudclk > > Just 'baud' ok > > > + - const: apb_pclk > > apb or pclk. pclk seems to be more common. > > > + > > + resets: > > + maxItems: 2 > > + > > + reset-names: > > + items: > > + - const: can > > + - const: can-apb > > They are always for 'can' so that's redundant. I guess it is fine on > the first entry, but definitely drop on the 2nd. Or do 'core' and 'apb'. I've picked core and apb. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung Nürnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Attachment:
signature.asc
Description: PGP signature
