Re: [PATCH can-next 11/21] can: rockchip_canfd: add functions to check if CAN-FD frames are equal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 30.07.2024 17:37:30, Simon Horman wrote:
> On Mon, Jul 29, 2024 at 03:05:42PM +0200, Marc Kleine-Budde wrote:
> > Add a pair new functions to check if 2 struct canfd_frame are equal.
> > The 1st checks if the header of the CAN frames are equal, the 2nd
> > checks if the data portion are equal:
> > 
> > - rkcanfd_can_frame_header_equal()
> > - rkcanfd_can_frame_data_equal()
> > 
> > This functionality is needed in the next patch.
> 
> nit: I would squash this into the next patch as
>      rkcanfd_can_frame_header_equal() is defined but
>      unused in this patch, which is flagged by
>      allmodconfig W=1 builds.

Makes sense, done.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux