On 15.07.2024 17:27:21, Frank Li wrote: > From: Chircu-Mare Bogdan-Petru <Bogdan.Chircu@xxxxxxxxxxxxx> > > Add flexcan support for S32V234. > > Signed-off-by: Chircu-Mare Bogdan-Petru <Bogdan.Chircu@xxxxxxxxxxxxx> > Signed-off-by: Dan Nica <dan.nica@xxxxxxx> > Signed-off-by: Stefan-Gabriel Mirea <stefan-gabriel.mirea@xxxxxxx> > Reviewed-by: Li Yang <leoyang.li@xxxxxxx> > Reviewed-by: Joakim Zhang <qiangqing.zhang@xxxxxxx> > Reviewed-by: Leonard Crestez <leonard.crestez@xxxxxxx> > Signed-off-by: Frank Li <Frank.Li@xxxxxxx> > --- > drivers/net/can/flexcan/flexcan-core.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/flexcan/flexcan-core.c > index 8ea7f2795551b..f6e609c388d55 100644 > --- a/drivers/net/can/flexcan/flexcan-core.c > +++ b/drivers/net/can/flexcan/flexcan-core.c > @@ -378,6 +378,10 @@ static const struct flexcan_devtype_data fsl_lx2160a_r1_devtype_data = { > FLEXCAN_QUIRK_SUPPORT_RX_MAILBOX_RTR, > }; > > +static struct flexcan_devtype_data fsl_s32v234_devtype_data = { > + .quirks = FLEXCAN_QUIRK_DISABLE_RXFG | FLEXCAN_QUIRK_DISABLE_MECR, > +}; - Does the core support CAN-FD? - Does the core generate an error interrupt when going from error warning to error passive? - Are you sure, you don't need to enable FLEXCAN_QUIRK_ENABLE_EACEN_RRS? - You probably want to use the mailboxes instead of the FIFO for the RX-path. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung Nürnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Attachment:
signature.asc
Description: PGP signature