Re: [PATCH can-next v2 00/15] can: kvaser_usb: Add hardware timestamp support to all devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue. 2 Jul. 2024 at 00:50, Jimmy Assarsson <extja@xxxxxxxxxx> wrote:
> From: Jimmy Assarsson <jimmyassarsson@xxxxxxxxx>
>
> This patch series add hardware timestamp support to all devices supported
> by the kvaser_usb driver.
>
> The first patches resolves a known issue; "Hardware timestamps are not set
> for CAN Tx frames". I can't remember why this wasn't implemented in the
> first version of the hydra driver.
>
> Followed by, hardware timestamp support for leaf and usbcan based devices.
>
> The final patches are removing code used for selecting the correct ethtool
> and netdev ops.
>
> Note: This patch series depends on patch
> "can: kvaser_usb: Explicitly initialize family in leafimx..." [1].
>
> [1] https://lore.kernel.org/linux-can/20240628194529.312968-1-extja@xxxxxxxxxx

Thanks for taking care of the TX timestamps!

I left one nitpick which is notwithstanding. With or without my
comment addressed and for the full series:

Reviewed-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>




[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux