On Sat. 29 June 2024 at 04:56, Jimmy Assarsson <extja@xxxxxxxxxx> wrote:
> Remove KVASER_USB_QUIRK_HAS_HARDWARE_TIMESTAMP, since all devices got
> hardware timestamp support.
>
> Signed-off-by: Jimmy Assarsson <extja@xxxxxxxxxx>
> ---
> drivers/net/can/usb/kvaser_usb/kvaser_usb.h | 1 -
> .../net/can/usb/kvaser_usb/kvaser_usb_core.c | 26 ++++++-------------
> 2 files changed, 8 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/net/can/usb/kvaser_usb/kvaser_usb.h b/drivers/net/can/usb/kvaser_usb/kvaser_usb.h
> index 5552140c0869..9fa02d8f49f9 100644
> --- a/drivers/net/can/usb/kvaser_usb/kvaser_usb.h
> +++ b/drivers/net/can/usb/kvaser_usb/kvaser_usb.h
> @@ -41,7 +41,6 @@
> #define KVASER_USB_QUIRK_HAS_SILENT_MODE BIT(0)
> #define KVASER_USB_QUIRK_HAS_TXRX_ERRORS BIT(1)
> #define KVASER_USB_QUIRK_IGNORE_CLK_FREQ BIT(2)
> -#define KVASER_USB_QUIRK_HAS_HARDWARE_TIMESTAMP BIT(3)
>
> /* Device capabilities */
> #define KVASER_USB_CAP_BERR_CAP 0x01
> diff --git a/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c b/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c
> index 576ddf932f47..a4f32d57173a 100644
> --- a/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c
> +++ b/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c
> @@ -94,29 +94,26 @@
> #define USB_MINI_PCIE_1XCAN_PRODUCT_ID 0x011B
(...)
> static const struct kvaser_usb_driver_info kvaser_usb_driver_info_leafimx = {
> - .quirks = KVASER_USB_QUIRK_HAS_HARDWARE_TIMESTAMP,
> + .quirks = 0,
> .family = KVASER_LEAF,
> .ops = &kvaser_usb_leaf_dev_ops,
> };
> @@ -862,14 +858,8 @@ static int kvaser_usb_init_one(struct kvaser_usb *dev, int channel)
>
> netdev->flags |= IFF_ECHO;
>
> - netdev->netdev_ops = &kvaser_usb_netdev_ops;
Ah, I missed this part. You can probably ignore this comment which I
made on patch 14:
https://lore.kernel.org/linux-can/CAMZ6RqJ8dyc62Hj+ACV99BSuX3g3ARGCfY4HHUtiKmpmmotDJw@xxxxxxxxxxxxxx/
> - if (driver_info->quirks & KVASER_USB_QUIRK_HAS_HARDWARE_TIMESTAMP) {
> - netdev->netdev_ops = &kvaser_usb_netdev_ops_hwts;
> - netdev->ethtool_ops = &kvaser_usb_ethtool_ops_hwts;
> - } else {
> - netdev->netdev_ops = &kvaser_usb_netdev_ops;
> - netdev->ethtool_ops = &kvaser_usb_ethtool_ops;
> - }
> + netdev->netdev_ops = &kvaser_usb_netdev_ops_hwts;
> + netdev->ethtool_ops = &kvaser_usb_ethtool_ops_hwts;
> SET_NETDEV_DEV(netdev, &dev->intf->dev);
> netdev->dev_id = channel;
>
> --
> 2.45.2
>
>
