On Sat. 29 June 2024 at 04:56, Jimmy Assarsson <extja@xxxxxxxxxx> wrote:
> Remove no longer used struct variables, kvaser_usb_ethtool_ops and
> kvaser_usb_netdev_ops.
Does the driver still compile after this patch? Wouldn't it be better
to squash patch 14 and 15 in one?
> Signed-off-by: Jimmy Assarsson <extja@xxxxxxxxxx>
> ---
> drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c b/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c
> index a4f32d57173a..4b6c23121b5d 100644
> --- a/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c
> +++ b/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c
> @@ -753,13 +753,6 @@ static netdev_tx_t kvaser_usb_start_xmit(struct sk_buff *skb,
> return ret;
> }
>
> -static const struct net_device_ops kvaser_usb_netdev_ops = {
> - .ndo_open = kvaser_usb_open,
> - .ndo_stop = kvaser_usb_close,
> - .ndo_start_xmit = kvaser_usb_start_xmit,
> - .ndo_change_mtu = can_change_mtu,
> -};
> -
> static const struct net_device_ops kvaser_usb_netdev_ops_hwts = {
> .ndo_open = kvaser_usb_open,
> .ndo_stop = kvaser_usb_close,
> @@ -768,10 +761,6 @@ static const struct net_device_ops kvaser_usb_netdev_ops_hwts = {
> .ndo_change_mtu = can_change_mtu,
> };
>
> -static const struct ethtool_ops kvaser_usb_ethtool_ops = {
> - .get_ts_info = ethtool_op_get_ts_info,
> -};
> -
> static const struct ethtool_ops kvaser_usb_ethtool_ops_hwts = {
> .get_ts_info = can_ethtool_op_get_ts_info_hwts,
> };
> --
> 2.45.2
>
>
