Hello,
This patch series tries to work around erratum DS80000789E 6 of the
mcp2518fd, found by Stefan Althöfer, the other variants of the chip
family (mcp2517fd and mcp251863) are probably also affected.
Erratum DS80000789E 6 says "reading of the FIFOCI bits in the FIFOSTA
register for an RX FIFO may be corrupted". However observation shows
that this problem is not limited to RX FIFOs but also effects the TEF
FIFO.
In the bad case, the driver reads a too large head index. In the
original code, the driver always trusted the read value.
For the RX FIDO this caused old, already processed CAN frames or new,
incompletely written CAN frames to be (re-)processed.
To work around this issue, keep a per FIFO timestamp of the last valid
received CAN frame and compare against the timestamp of every received
CAN frame.
Further tests showed that this workaround can recognize old CAN
frames, but a small time window remains in which partially written CAN
frames are not recognized but then processed. These CAN frames have
the correct data and time stamps, but the DLC has not yet been
updated.
For the TEF FIFO the original driver already detects the error, update
the error handling with the knowledge that it is causes by this erratum.
The series applies against current net/main or net-next/main +
d8fb63e46c88 ("can: mcp251xfd: fix infinite loop when xmit fails")
regards,
Marc
Closes: https://lore.kernel.org/all/FR0P281MB1966273C216630B120ABB6E197E89@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
---
Changes in v4:
- 7/9: mcp251xfd_ring_alloc(): replace BITS_PER_TYPE(u8) by
BITS_PER_TYPE(rx_ring->obj_num_shift_to_u8) to calculate
rx_ring->obj_num_shift_to_u8
- 7/9 mcp251xfd_get_rx_len(): add BUILD_BUG_ON() to ensure that all
variables used in calculation are actually u8
- 9/9: mcp251xfd_ring_alloc(): replace BITS_PER_TYPE(u8) by
BITS_PER_TYPE(tx_ring->obj_num) to calculate
tx_ring->obj_num_shift_to_u8
- 9/9: mcp251xfd_get_tef_len(): add BUILD_BUG_ON() to ensure that all
variables used in calculation are actually u8
- Link to v3: https://lore.kernel.org/all/20240624-mcp251xfd-workaround-erratum-6-v3-0-caf7e5f27f60@xxxxxxxxxxxxxx
Changes in v3:
- 1/9: can: mcp251xfd: properly indent labels:
- new
- 2/9: can: mcp251xfd: update errata references:
- new
- 3/9: can: mcp251xfd: move mcp251xfd_timestamp_start()/stop() into mcp251xfd_chip_start/stop()
- split mcp251xfd_timestamp_init() into mcp251xfd_timestamp_init()
and mcp251xfd_timestamp_start()
- update patch description
- 6/9: can: mcp251xfd: rx: prepare to workaround broken RX FIFO head index erratum
- update comments
- update patch description
- 7/9: can: mcp251xfd: rx: add workaround for erratum DS80000789E 6 of mcp2518fd
- update comments
- update patch description
- 8/9: new
- import 1/2 from https://lore.kernel.org/all/20230124152729.814840-1-mkl@xxxxxxxxxxxxxx
- 9/9: new
- import 2/2 from https://lore.kernel.org/all/20230124152729.814840-1-mkl@xxxxxxxxxxxxxx
- Link to v2: https://lore.kernel.org/all/20230119112842.500709-1-mkl@xxxxxxxxxxxxxx
Changes in v2
- all:
- add proper patch description
- added Tested-by
- 2/5 can: mcp251xfd: clarify the meaning of timestamp:
- revisited new naming of variables and functions
now we use ts_raw instead of tbc
- 4/5 can: mcp251xfd: rx: prepare to workaround broken RX:
- precalculate shift width needed for full u8 instead of calculating
it every time
- 5/5 can: mcp251xfd: rx: workaround broken RX FIFO head:
- remove dumping of old CAN frame in error case
- add erratum comments
- Link to v1: v1: https://lore.kernel.org/all/20230111222042.1139027-1-mkl@xxxxxxxxxxxxxx
---
Marc Kleine-Budde (9):
can: mcp251xfd: properly indent labels
can: mcp251xfd: update errata references
can: mcp251xfd: move mcp251xfd_timestamp_start()/stop() into mcp251xfd_chip_start/stop()
can: mcp251xfd: clarify the meaning of timestamp
can: mcp251xfd: mcp251xfd_handle_rxif_ring_uinc(): factor out in separate function
can: mcp251xfd: rx: prepare to workaround broken RX FIFO head index erratum
can: mcp251xfd: rx: add workaround for erratum DS80000789E 6 of mcp2518fd
can: mcp251xfd: tef: prepare to workaround broken TEF FIFO tail index erratum
can: mcp251xfd: tef: update workaround for erratum DS80000789E 6 of mcp2518fd
drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 82 +++++-----
drivers/net/can/spi/mcp251xfd/mcp251xfd-dump.c | 2 +-
drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c | 2 +-
drivers/net/can/spi/mcp251xfd/mcp251xfd-ring.c | 5 +
drivers/net/can/spi/mcp251xfd/mcp251xfd-rx.c | 165 ++++++++++++++-------
drivers/net/can/spi/mcp251xfd/mcp251xfd-tef.c | 129 ++++++++--------
.../net/can/spi/mcp251xfd/mcp251xfd-timestamp.c | 29 ++--
drivers/net/can/spi/mcp251xfd/mcp251xfd.h | 56 +++----
8 files changed, 269 insertions(+), 201 deletions(-)
---
base-commit: 748e3bbf47212d5e2e22d731328b0c15ee3b85ae
change-id: 20240505-mcp251xfd-workaround-erratum-6-2e82c4c62fd3
Best regards,
--
Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
