On 2024-06-07 at 16:22:08, Martin Hundebøll (martin@xxxxxxxxxx) wrote:
>
> - usleep_range(1, 5);
> + /* Then clear the it again. */
> + ret = m_can_cccr_update_bits(cdev, CCCR_NISO, 0);
> + if (ret) {
> + dev_err(cdev->dev, "failed to revert the NON-ISO bit in CCCR\n");
> + return ret;
> }
>
> - /* Clear NISO */
> - cccr_reg &= ~(CCCR_NISO);
> - m_can_write(cdev, M_CAN_CCCR, cccr_reg);
> + ret = m_can_config_disable(cdev);
> + if (ret)
> + return ret;
if ret != 0, then the function returns "true", right ?
as indicated by the below comment. But as i understand,
this is an error case and should return "false"
> - /* return false if time out (-ETIMEDOUT), else return true */
> - return !niso_timeout;
> + return niso == 0;
> }
>
>
