On 22.04.24 07:50, Vincent Mailhol wrote:
On Sun. 21 Apr. 2024 at 04:48, Oliver Hartkopp <socketcan@xxxxxxxxxxxx> wrote:
With the new ISO 15765-2:2024 release the former documentation and comments
have to be reworked. This patch removes the ISO specification version/date
where possible.
The patch also renames "classical CAN" into "CAN CC", which is fine
but maybe add one sentence in the patch description for that.
Hm, IMO this is an editorial update without any new information.
Aside from that nitpick, one comment (see below). Meanwhile, I am
giving my acknowledgement in advance:
Acked-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>
Thank you.
Signed-off-by: Oliver Hartkopp <socketcan@xxxxxxxxxxxx>
---
include/uapi/linux/can/isotp.h | 2 +-
net/can/Kconfig | 11 +++++------
net/can/isotp.c | 11 ++++++-----
3 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/include/uapi/linux/can/isotp.h b/include/uapi/linux/can/isotp.h
index 6cde62371b6f..bd990917f7c4 100644
--- a/include/uapi/linux/can/isotp.h
+++ b/include/uapi/linux/can/isotp.h
@@ -1,10 +1,10 @@
/* SPDX-License-Identifier: ((GPL-2.0-only WITH Linux-syscall-note) OR BSD-3-Clause) */
/*
* linux/can/isotp.h
*
- * Definitions for isotp CAN sockets (ISO 15765-2:2016)
+ * Definitions for ISO 15765-2 CAN transport protocol sockets
*
* Copyright (c) 2020 Volkswagen Group Electronic Research
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
diff --git a/net/can/Kconfig b/net/can/Kconfig
index cb56be8e3862..af64a6f76458 100644
--- a/net/can/Kconfig
+++ b/net/can/Kconfig
@@ -54,20 +54,19 @@ config CAN_GW
by the netlink configuration interface known e.g. from iptables.
source "net/can/j1939/Kconfig"
config CAN_ISOTP
- tristate "ISO 15765-2:2016 CAN transport protocol"
+ tristate "ISO 15765-2 CAN transport protocol"
help
CAN Transport Protocols offer support for segmented Point-to-Point
communication between CAN nodes via two defined CAN Identifiers.
+ This protocol driver implements segmented data transfers for CAN CC
+ (aka Classical CAN, CAN 2.0B) and CAN FD frame types which were
+ introduced with ISO 15765-2:2016.
As CAN frames can only transport a small amount of data bytes
- (max. 8 bytes for 'classic' CAN and max. 64 bytes for CAN FD) this
+ (max. 8 bytes for CAN CC and max. 64 bytes for CAN FD) this
segmentation is needed to transport longer Protocol Data Units (PDU)
as needed e.g. for vehicle diagnosis (UDS, ISO 14229) or IP-over-CAN
traffic.
- This protocol driver implements data transfers according to
- ISO 15765-2:2016 for 'classic' CAN and CAN FD frame types.
- If you want to perform automotive vehicle diagnostic services (UDS),
- say 'y'.
Not sure why that last sentence was removed. This is out of scope from
this patch and I think this can be helpful for the audience not aware
that UDS relies on ISO-TP. I suggest keeping that one.
This is a repetition of ...
"segmentation is needed to transport longer Protocol Data Units (PDU) as
needed e.g. for vehicle diagnosis (UDS, ISO 14229) or IP-over-CAN traffic."
... one sentence before.
Therefore I thought it could be removed.
Best regards,
Oliver
