Re: [Wireshark-dev] [PATCH 0/4] Wireshark SocketCAN updates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Gerald,

thanks for the pointer and the excellent documentation!!
That was a 10 minutes job:

https://gitlab.com/wireshark/wireshark/-/merge_requests/14886

I assumed the Wireshark development process taking place on the mailing list - but GitLab is even better. Happy review ;-)

Many thanks and best regards,
Oliver

On 2024-03-18 17:37, Gerald Combs wrote:
Thanks for your contribution! Can you submit a merge request at

https://gitlab.com/wireshark/wireshark/ ?

Complete documentation on contributing code to Wireshark can be found in our Developer's Guide at

https://www.wireshark.org/docs/wsdg_html/#ChSrcContribute

On 3/18/24 3:46 AM, Oliver Hartkopp via Wireshark-dev wrote:
This patchset simplifies the CAN packet type detection as it focusses
on the rules to distiguish the different CAN CC/FD/XL frames from the
Linux kernel API.

Additionally some more content is shown in the dissector and the
CAN CiA 611-1 definitions have been cleaned up and extended by CiA.

Oliver Hartkopp (4):
   socketcan: simplify CAN packet type detection
   socketcan: display CANFD_FDF and CANXL_XLF flag content
   socketcan: display len8dlc content for Classical CAN
   socketcan: update CAN CiA 611-1 definitions

  epan/dissectors/packet-socketcan.c | 86 ++++++++++--------------------
  epan/dissectors/packet-socketcan.h | 17 +++---
  2 files changed, 39 insertions(+), 64 deletions(-)






[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux