Re: [PATCH v2 0/5] can: dev: fix can_restart() and replace BUG_ON() by error handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06.10.2023 01:07:33, Vincent Mailhol wrote:
> On Thu. 5 Oct. 2023 at 23:36, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote:
> > There are 2 BUG_ON() in the CAN dev helpers. During the update/test of
> > the at91_can driver to rx-offload the one in can_restart() was
> > triggered, due to a race condition in can_restart() and a hardware
> > limitation of the at91_can IP core.
> >
> > This series fixes the race condition, replaces BUG_ON() with an error
> > message, and does some cleanup. Finally, the BUG_ON() in
> > can_put_echo_skb() is also replaced with error handling.
> >
> > Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> 
> Notwithstanding of my nitpick on patch 4/5:
> 
> Reviewed-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>
> 
> Side note, I did not received patch 1/5, 3/5 and 5/5 from this v2 and
> I do not see them either on
> https://lore.kernel.org/linux-can/20231005-can-dev-fix-can-restart-v2-0-91b5c1fd922c@xxxxxxxxxxxxxx/T/#me6e1b1ced8ceca1a3bc27b9b36b582a286fd259a
> Note sure if this is a send error on your end or some congestion on
> the mailing list.

It took me quite a long time to get these messages and there were also
some messages missing (don't remember which ones). But if you download
them with:

| b4 mbox 20231005-can-dev-fix-can-restart-v2-0-91b5c1fd922c@xxxxxxxxxxxxxx

you get the whole series.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux