Re: [net-next PATCH v2 3/4] netdev: replace napi_reschedule with napi_schedule

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Eric Dumazet <edumazet@xxxxxxxxxx>
Subject: Re: [net-next PATCH v2 3/4] netdev: replace napi_reschedule with napi_schedule
From: Jakub Kicinski <kuba@xxxxxxxxxx>
Date: Thu, 5 Oct 2023 09:32:53 -0700
Cc: Christian Marangi <ansuelsmth@xxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxx>, Leon Romanovsky <leon@xxxxxxxxxx>, Wolfgang Grandegger <wg@xxxxxxxxxxxxxx>, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Chris Snook <chris.snook@xxxxxxxxx>, Raju Rangoju <rajur@xxxxxxxxxxx>, Jeroen de Borst <jeroendb@xxxxxxxxxx>, Praveen Kaligineedi <pkaligineedi@xxxxxxxxxx>, Shailend Chand <shailend@xxxxxxxxxx>, Douglas Miller <dougmill@xxxxxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, Christophe Leroy <christophe.leroy@xxxxxxxxxx>, Nick Child <nnac123@xxxxxxxxxxxxx>, Haren Myneni <haren@xxxxxxxxxxxxx>, Rick Lindsley <ricklind@xxxxxxxxxxxxx>, Dany Madden <danymadden@xxxxxxxxxx>, Thomas Falcon <tlfalcon@xxxxxxxxxxxxx>, Tariq Toukan <tariqt@xxxxxxxxxx>, Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>, Jose Abreu <joabreu@xxxxxxxxxxxx>, Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>, Krzysztof Halasa <khalasa@xxxxxxx>, Kalle Valo <kvalo@xxxxxxxxxx>, Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>, Gregory Greenman <gregory.greenman@xxxxxxxxx>, Chandrashekar Devegowda <chandrashekar.devegowda@xxxxxxxxx>, Intel Corporation <linuxwwan@xxxxxxxxx>, Chiranjeevi Rapolu <chiranjeevi.rapolu@xxxxxxxxxxxxxxx>, Liu Haijun <haijun.liu@xxxxxxxxxxxx>, M Chetan Kumar <m.chetan.kumar@xxxxxxxxxxxxxxx>, Ricardo Martinez <ricardo.martinez@xxxxxxxxxxxxxxx>, Loic Poulain <loic.poulain@xxxxxxxxxx>, Sergey Ryazanov <ryazanov.s.a@xxxxxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, Yuanjun Gong <ruc_gongyuanjun@xxxxxxx>, Simon Horman <horms@xxxxxxxxxx>, Rob Herring <robh@xxxxxxxxxx>, Ziwei Xiao <ziweixiao@xxxxxxxxxx>, Rushil Gupta <rushilg@xxxxxxxxxx>, Coco Li <lixiaoyan@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Junfeng Guo <junfeng.guo@xxxxxxxxx>, Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>, Wei Fang <wei.fang@xxxxxxx>, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>, Yuri Karpov <YKarpov@xxxxxxxxx>, Zhengchao Shao <shaozhengchao@xxxxxxxxxx>, Andrew Lunn <andrew@xxxxxxx>, Zheng Zengkai <zhengzengkai@xxxxxxxxxx>, Lee Jones <lee@xxxxxxxxxx>, Maximilian Luz <luzmaximilian@xxxxxxxxx>, "Rafael J. Wysocki" <rafael.j.wysocki@xxxxxxxxx>, Dawei Li <set_pte_at@xxxxxxxxxxx>, Anjaneyulu <pagadala.yesu.anjaneyulu@xxxxxxxxx>, Benjamin Berg <benjamin.berg@xxxxxxxxx>, linux-rdma@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-can@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, ath10k@xxxxxxxxxxxxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx
In-reply-to: <CANn89iK226C-pHUJm7HKMyEtMycGC=KCA2M6kw2KJaUj0cCT6w@mail.gmail.com>
References: <20231003145150.2498-1-ansuelsmth@gmail.com> <20231003145150.2498-3-ansuelsmth@gmail.com> <CANn89iK226C-pHUJm7HKMyEtMycGC=KCA2M6kw2KJaUj0cCT6w@mail.gmail.com>

On Thu, 5 Oct 2023 18:11:56 +0200 Eric Dumazet wrote:
> OK, but I suspect some users of napi_reschedule() might not be race-free...

What's the race you're thinking of?

Follow-Ups:
- Re: [net-next PATCH v2 3/4] netdev: replace napi_reschedule with napi_schedule
  - From: Eric Dumazet

References:
- [net-next PATCH v2 1/4] netdev: replace simple napi_schedule_prep/__napi_schedule to napi_schedule
  - From: Christian Marangi
- [net-next PATCH v2 3/4] netdev: replace napi_reschedule with napi_schedule
  - From: Christian Marangi
- Re: [net-next PATCH v2 3/4] netdev: replace napi_reschedule with napi_schedule
  - From: Eric Dumazet

Prev by Date: Re: [PATCH v2 4/5] can: dev: can_restart(): update debug and error messages
Next by Date: [PATCH v2 27/27] can: at91_can: switch to rx-offload implementation
Previous by thread: Re: [net-next PATCH v2 3/4] netdev: replace napi_reschedule with napi_schedule
Next by thread: Re: [net-next PATCH v2 3/4] netdev: replace napi_reschedule with napi_schedule
Index(es):
- Date
- Thread

[Index of Archives] [Automotive Discussions] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API] [CAN Bus]